git.shiar.nl
/
minimedit.git
/ commitdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
| commitdiff |
tree
raw
|
patch
| inline |
side by side
(from parent 1:
c9b5461
)
upload: disallow overwrites of existing file names
author
Mischa POSLAWSKY
<perl@shiar.org>
Wed, 7 Apr 2021 15:37:36 +0000
(17:37 +0200)
committer
Mischa POSLAWSKY
<perl@shiar.org>
Tue, 27 Apr 2021 00:45:24 +0000
(
02:45
+0200)
Not a solution for reusing the same name, but prevents silent replacement
allowing the user to retry.
Reported-by: Fulco Jongsma
upload.inc.php
patch
|
blob
|
history
diff --git
a/upload.inc.php
b/upload.inc.php
index 6175fe20a685b1b1df707ccba8e74f4bad2564f1..e70f5738a3bfacafa1a4013b42f5905010c7d676 100644
(file)
--- a/
upload.inc.php
+++ b/
upload.inc.php
@@
-27,6
+27,9
@@
function userupload($input, $target = NULL, $filename = NULL)
$target .= $input['name'];
}
+ if (file_exists($target)) {
+ throw new Exception("bestandsnaam al aanwezig op $target");
+ }
if (!@move_uploaded_file($input['tmp_name'], $target)) {
throw new Exception("bestand kon niet worden opgeslagen in $target");
}