From 802e8d5b79d157f75c639c11b6cd1cacf4b0ec8a Mon Sep 17 00:00:00 2001
From: Mischa POSLAWSKY <perl@shiar.org>
Date: Mon, 27 May 2019 21:20:46 +0200
Subject: [PATCH] browser: warn about significant ignores of wikimedia browsers

Prevent future changes (either due to popularity or upstream renames)
from going unnoticed.  Unsupported input should be explicitly marked.
---
 tools/mkusage-wikimedia | 11 +++++++++--
 1 file changed, 9 insertions(+), 2 deletions(-)

diff --git a/tools/mkusage-wikimedia b/tools/mkusage-wikimedia
index a4ca1cd..bf893ce 100755
--- a/tools/mkusage-wikimedia
+++ b/tools/mkusage-wikimedia
@@ -4,7 +4,7 @@ use warnings;
 
 use Data::Dump 'pp';
 
-our $VERSION = '1.00';
+our $VERSION = '1.01';
 
 my %BROWSERID = qw(
 	IE                      ie
@@ -25,6 +25,7 @@ my %BROWSERID = qw(
 	Opera-Mini              op_mini
 	BlackBerry-WebKit       bb
 	UC-Browser              and_uc
+	Other                   0
 );
 
 my %count = (
@@ -37,10 +38,16 @@ my $recent = qr/^2018-/;
 (readline =~ y/\t//) == 3 or die "unexpected amount of columns in header\n";
 
 while (my $row = readline) {
+	$row =~ s/\r?\n\z//;
 	my ($date, $name, $version, $pct) = split /\t/, $row;
 	$date =~ $recent or next;
 	$name =~ y/ /-/;
-	my $browser = $BROWSERID{$name} or next;
+	my $browser = $BROWSERID{$name};
+	if (not $browser) {
+		warn "unknown browser: $name v$version ($pct)\n"
+			unless defined $browser or $pct < .005;
+		next;
+	}
 	$version =~ s/\A-\z/0/;
 	$count{$browser}{$version} += $pct;
 	$count{-total} += $pct;
-- 
2.30.0