From: Mischa POSLAWSKY <perl@shiar.org>
Date: Thu, 7 Aug 2008 23:33:50 +0000 (+0000)
Subject: prefer logical over ternary conditionals
X-Git-Tag: v1.2~72
X-Git-Url: http://git.shiar.nl/sheet.git/commitdiff_plain/a7550acbfb812044fa2804a27849da4b124d2b61

prefer logical over ternary conditionals
---

diff --git a/index.plp b/index.plp
index ed49475..01a3bf2 100644
--- a/index.plp
+++ b/index.plp
@@ -160,7 +160,7 @@ for (my $row = 0; $row <= $#$keyrows; $row++) {
 			  @$keycase or next;
 
 			printf(qq{\t<li%s><h3>%s</h3>\n}, # XXX insert &nbsp; here to fix msie<=6
-				$mode eq '' ? '' : sprintf(
+				$mode ne '' && sprintf(
 					' class="%s"', 'mode mode' . escapeclass($mode)
 				),
 				sprintf('%s<small>: %s</small>',
@@ -223,13 +223,13 @@ for (my $row = 0; $row <= $#$keyrows; $row++) {
 		<li>keyboard <strong>map</strong> is
 			<:= $get{map} ? 'set to ' : '' :><em><:= $map :></em>
 		<li><strong>ascii</strong> mode is
-			<:= exists $get{ascii} ? 'forced ' : '' :><em><:=
+			<:= exists $get{ascii} && 'forced ' :><em><:=
 				$ascii ? 'on' : 'off' :></em>
 		<li><strong>keys</strong> are
 			<em><:= $showkeys ? 'always shown' : 'hidden if unassigned' :></em><:=
-				exists $get{keys} ? '' : ' by default' :>
+				exists $get{keys} || ' by default' :>
 		<li>default <strong>style</strong> is
-			<:= defined $get{style} ? 'set to ' : '' :><em><:= $style :></em>
+			<:= defined $get{style} && 'set to ' :><em><:= $style :></em>
 		</ul>
 	</div>
 </div>