browser: fix duplicate versions in total browser usage
authorMischa POSLAWSKY <perl@shiar.org>
Wed, 8 Dec 2010 22:32:59 +0000 (23:32 +0100)
committerMischa POSLAWSKY <perl@shiar.org>
Wed, 15 Dec 2010 21:40:44 +0000 (22:40 +0100)
browser.plp

index 19011ab21d91ae8b601244de11f0f2ce58a32ed4..02e7e0b7a2481d72d08333392883e5e7481177c6 100644 (file)
@@ -99,9 +99,10 @@ if ($usage) {
                $row->{$_} //= undef for @$verlist;  # ensure stable keys during iteration
                while (my ($version, $usage) = each %$row) {
                        next if defined $supported{$version};
-                       $_ = paddedver($_) for $version;
-                       my $next = first { paddedver($_) ge $version } @$verlist; # or next
+                       my $next = first { paddedver($_) ge paddedver($version) } @$verlist
+                               or warn("No fallback found for $browser v$version; $usage% ignored"), next;
                        $row->{$next} += $usage;
+                       $row->{$version} = 0;  # balance browser total
                }
        }
 }