No partial parameter shifting. Use /x and // operator for readability.
Same results.
sub print_rows {
my $self = shift;
sub print_rows {
my $self = shift;
+ my ($rowsspec, $defrows) = @_;
+ $defrows ||= [2, 1, 0];
- -DEFAULT => !!@_ && $_[0] ne '' && split(/(?:\s*([^=\s]*)=\s*)/, shift),
+ -DEFAULT => defined $rowsspec && $rowsspec ne '' &&
+ split(/\s* ([^=\s]*) = \s*/x, $rowsspec),
# plus specific mode overrides prefixed by '='
);
# plus specific mode overrides prefixed by '='
);
- my $defrows = shift || [2, 1, 0];
my @modes = sort keys %{ $self->{def} };
print '<table id="rows" class="keys">'."\n\n";
my @modes = sort keys %{ $self->{def} };
print '<table id="rows" class="keys">'."\n\n";
for my $basemode (@modes) {
my @moderows = split /\s+/,
$row < 0 ? "0" :
for my $basemode (@modes) {
my @moderows = split /\s+/,
$row < 0 ? "0" :
- defined $moderows{$basemode} ? $moderows{$basemode} : $moderows{-DEFAULT};
+ $moderows{$basemode} // $moderows{-DEFAULT};
for my $submode (@moderows ? @moderows : '') {
my $mode = $basemode . $submode;
for my $submode (@moderows ? @moderows : '') {
my $mode = $basemode . $submode;