X-Git-Url: http://git.shiar.nl/sheet.git/blobdiff_plain/2645cbf6f7364951ad8dc72649361844181c2b20..b86bbb8de10c94737088dbc8b3c8c2fd9d7d0770:/sc.plp

diff --git a/sc.plp b/sc.plp
index 19149cf..3c19fce 100644
--- a/sc.plp
+++ b/sc.plp
@@ -20,18 +20,25 @@ my %scvers = (
 		game => 'StarCraft II LotV',
 		major => 2,
 	},
+	index => 'bw',
+	1     => 'bw',
+	2     => 'lotv',
 );
 
-$Request ||= 'bw';
-$Request = 'lotv' if $Request eq '2';
-my %scver = %{ $scvers{$Request} // {} }
+my $requestver = $scvers{$Request ||= 'index'}
 	or Html(), Abort("Requested version <q>$Request</q> not available", '404 request not found');
 
-my $datafile = "sc-units-$Request.inc.pl";
+if (ref $requestver ne 'HASH') {
+	$header{Location} = "/sc/$requestver";
+	Abort("Canonical URL for $Request is at $requestver", '302 subpage alias');
+}
+
+my %scver = %{$requestver};
+my $datafile = "sc-units-$Request";
 
 Html({
 	title => "$scver{title} unit cheat sheet",
-	version => '1.2',
+	version => '1.3',
 	description => [
 		"Reference of $scver{game} unit properties,"
 		. " comparing various statistics of all the units in $scver{name}"
@@ -47,13 +54,12 @@ Html({
 	],
 	stylesheet => [qw( light dark )],
 	raw => '<link rel="stylesheet" type="text/css" media="all" href="/sc.css?1.2">',
-	data => [$datafile],
+	data => ["$datafile.inc.pl"],
 });
 
 say "<h1>$scver{game} units</h1>\n";
 
-my $units = do $datafile;
-Abort("Cannot open unit data", 501, $_) for $@ || $! || ();
+my $units = Data($datafile);
 my $patch = shift @{$units}
 	or Abort("Cannot open unit data: metadata not found", 501);
 
@@ -172,15 +178,16 @@ sub showrangeint {
 			if $attack->{type} eq 'implosive';
 	if (my @bonus = sort grep { !/^-/ } keys %{ $attack->{bonus} }) {
 		$out .= sprintf('<span class="%s" title="%s">&ge;</span>',
-			(map {
+			(
 				$_ eq 'light' ? 'unit-s' :
 				$_ eq 'armored' ? 'unit-l' :
 				$_ eq 'organic' ? 'unit-o' :
 				$_ eq 'massive' ? 'unit-h' :
 				$_ eq 'shields' ? 'unit-shield' :
+				$_ eq 'structure' ? 'unit-x' :
 				'',
-			} join '_', @bonus),
-			join(', ', map {(
+			),
+			(
 				sprintf('+%s vs %s',
 					showrangeint(
 						$attack->{bonus}->{$_},
@@ -189,8 +196,8 @@ sub showrangeint {
 					),
 					$_,
 				),
-			)} @bonus),
-		);
+			),
+		) for @bonus;
 	}
 		$out .= '<span class="unit-pdd" title="projectile">•</span>'
 			if $attack->{type} eq 'projectile';
@@ -246,7 +253,7 @@ sub showrangeint {
 			sprintf '<span%s title="%s">%s</span>',
 				$_->{duration} < 0 && ' class="magic-perma"',
 				join('',
-					$_->{name},
+					$_->{name} // $_->{alt},
 					$_->{desc} ? ": $_->{desc}" : '',
 					(map { $_ && " ($_)" } join ', ',
 						#TODO: apply upgrades
@@ -349,12 +356,11 @@ sub showrangeint {
 			$_->{attr}->{jump}
 				&& qq'<span class="unit unit-jump" title="$_->{attr}->{jump}">↕</span>',
 			'<td class="unit-magic">' . showmagic($_),
-			!$_->{attack}->[1] ? () : (
-				'<tr><th class="cat" colspan="2"><td colspan=10>', showattack($_, 1), '<td colspan=3>'
-			),
-			!$_->{attack}->[2] ? () : (
-				'<tr><th class="cat" colspan="2"><td colspan=10>', showattack($_, 2), '<td colspan=3>'
-			),
+			(map {(
+				'<tr class="sub"><th class="cat"><td><td colspan=10>',
+				showattack($row, $_),
+				'<td colspan=3>',
+			)} 1 .. $#{ $_->{attack} }),
 			"\n"
 		);
 	}
@@ -393,7 +399,7 @@ sub showrangeint {
 			) for @rows;
 		}
 		elsif ($get{order} eq 'attack') {
-			$_->{order} = $_->{hp} / 1024 + $_->{shield} / 1008 + max(
+			$_->{order} = $_->{hp} / 16384 + max(
 				map {
 					($_->{dps} ? $_->{dps}->[-1] :
 						($_->{damage} + $_->{upgrade} * 3)