prefer logical over ternary conditionals

[sheet.git] / index.plp

diff --git a/index.plp b/index.plp
index ed4947587bdbebf563e852576bbf90d60a8ff37a..01a3bf2dc4a6bd5338c88766edda0dcffa428203 100644 (file)
--- a/index.plp
+++ b/index.plp
@@ -160,7 +160,7 @@ for (my $row = 0; $row <= $#$keyrows; $row++) {
                          @$keycase or next;
 
                        printf(qq{\t<li%s><h3>%s</h3>\n}, # XXX insert &nbsp; here to fix msie<=6
-                               $mode eq '' ? '' : sprintf(
+                               $mode ne '' && sprintf(
                                        ' class="%s"', 'mode mode' . escapeclass($mode)
                                ),
                                sprintf('%s<small>: %s</small>',
@@ -223,13 +223,13 @@ for (my $row = 0; $row <= $#$keyrows; $row++) {
                <li>keyboard <strong>map</strong> is
                        <:= $get{map} ? 'set to ' : '' :><em><:= $map :></em>
                <li><strong>ascii</strong> mode is
-                       <:= exists $get{ascii} ? 'forced ' : '' :><em><:=
+                       <:= exists $get{ascii} && 'forced ' :><em><:=
                                $ascii ? 'on' : 'off' :></em>
                <li><strong>keys</strong> are
                        <em><:= $showkeys ? 'always shown' : 'hidden if unassigned' :></em><:=
-                               exists $get{keys} ? '' : ' by default' :>
+                               exists $get{keys} || ' by default' :>
                <li>default <strong>style</strong> is
-                       <:= defined $get{style} ? 'set to ' : '' :><em><:= $style :></em>
+                       <:= defined $get{style} && 'set to ' :><em><:= $style :></em>
                </ul>
        </div>
 </div>