From: Mischa POSLAWSKY <perl@shiar.org>
Date: Wed, 22 May 2019 17:25:58 +0000 (+0200)
Subject: return not found response for missing requests
X-Git-Tag: v0.4~5
X-Git-Url: http://git.shiar.nl/sc2-widget/commitdiff_plain/b4c80b59335b9905191da1e9be35e82487ff36e7

return not found response for missing requests

Wrapper can differentiate invalid requests immediately.
---

diff --git a/widget.php b/widget.php
index eec0637..736a7b1 100644
--- a/widget.php
+++ b/widget.php
@@ -18,13 +18,17 @@ function error($message, $status = 500)
 }
 
 $request = trim($_SERVER['PATH_INFO'], '/');
-if (!file_exists("$request.json")) {
+$target = "$request.json";
+if (!file_exists($target)) {
 	if (!is_numeric($request)) {
 		error("Unknown profile request <q>$request</q>", 400);
 	}
-	system("./getsc2clan $request | sponge $request.json", $exitcode);
+	system("./getsc2clan $request | sponge $target", $exitcode);
 	if ($exitcode) {
 		error("No results for profile id $request from Blizzard", 503);
 	}
 }
+if (!filesize($target)) {
+	error("No clan data for <q>$request</q>", 404);
+}
 require('widget.html');