From: Mischa POSLAWSKY <perl@shiar.org>
Date: Fri, 15 Jan 2021 10:23:19 +0000 (+0100)
Subject: foto: escape html (ampersands) in album links
X-Git-Tag: v5.2~13
X-Git-Url: http://git.shiar.nl/minimedit.git/commitdiff_plain/b28c58864e20c556b65ec60f02c0df6401f73351

foto: escape html (ampersands) in album links

Fix broken entity Lijtweg directory <verbouw&opknap>.
---

diff --git a/foto/index.php b/foto/index.php
index a6378ef..49e5483 100644
--- a/foto/index.php
+++ b/foto/index.php
@@ -72,22 +72,22 @@ if ($imgs = glob("$rootdir/*", GLOB_ONLYDIR)) {
 	natsort($imgs);
 	print '<ul class="gallery cat">'."\n";
 	foreach ($imgs as $path) {
-		$parts = pathinfo($path);
-		$album = $parts['filename'];
+		$album = htmlspecialchars(pathinfo($path, PATHINFO_FILENAME));
 		$cover = "$path/index.jpg";
 		if (!file_exists($cover)) $cover = 'foto/index.jpg';
 		if (is_link($cover)) {
 			$cover = preg_replace('{^(?:\.\./)*(?=data/)}', 'thumb/100/', readlink($cover));
 		}
 
-		$html = '<img src="/'.$cover.'" />';
+		$html = sprintf('<img src="/%s" />', htmlspecialchars($cover));
 		$html .= "<figcaption>$album</figcaption>";
 		if (!$User->login and file_exists("$path/.private")) {
 			$html = '<s title="bewoners">'.$html.'</s>';
 		}
 		$html = "<figure>$html</figure>";
 
-		printf('<li id="%s"><a href="%s">%s</a>'."\n", $album, "/$path", $html);
+		printf('<li id="%s">', $album);
+		printf('<a href="/%s">%s</a>'."\n", htmlspecialchars($path), $html);
 	}
 	print "</ul>\n\n";
 }