From: Mischa POSLAWSKY Date: Tue, 26 Nov 2019 16:24:05 +0000 (+0100) Subject: issue: populate ticket data before reply include X-Git-Tag: v4.2^0 X-Git-Url: http://git.shiar.nl/minimedit.git/commitdiff_plain/a875a31121144d25bd59bb72aa2afd8a5565c853 issue: populate ticket data before reply include Reorder in commit v4.1-34-gc83e7f0379 (2019-11-25) [issue: include replies before issue retrieval] breaks admin features due to missing $Issue. Update row data on update instead. --- diff --git a/issue/index.php b/issue/index.php index 1e7bba5..cefe00f 100644 --- a/issue/index.php +++ b/issue/index.php @@ -6,13 +6,13 @@ require_once 'database.inc.php'; if ($id and ctype_digit($id)) { $Article->title = "Issue #$id"; $Args = "/$id"; # minimal reference - $replies = placeholder_include('reply'); # handle before retrieval - $Issue = $Db->query( 'SELECT * FROM issues WHERE page = ? AND id = ?', [$Page, $id] )->fetch(); if (!$Issue) throw new Exception('Issuenummer niet gevonden'); + $replies = placeholder_include('reply'); # handle updates + $Article->title .= ': '.htmlspecialchars($Issue->subject); print "

{$Article->title}

\n"; print "
\n"; diff --git a/widget/reply.php b/widget/reply.php index 94018c4..fd01a94 100644 --- a/widget/reply.php +++ b/widget/reply.php @@ -46,6 +46,7 @@ if ($_POST) { 'value' => $updated->$col, ]); } + $Issue = $updated; } } $_POST['reply'] = NULL;